Closed petercable closed 9 years ago
s-pearce
commented
9 years ago @petercable Good catch. Were you guys trying to integrate the 2015 WMM coefficients when this issue came up? With this bug fix will the 2015-2020 model now be implemented? -Stuart
petercable
commented
9 years ago I was trying to create a working install using setup.py and found that no WMM coefficients file was being deployed. I assume the original file was named WMM.COF at some point in time... I don't have any idea if there is any effort to implement a new model (but the code looks like it should support it just fine!)
I had also considered submitting a pull request to soften the module requirements a little by marking versions as >= XX.XX.XX so that we could accept newer versions of packages. I was having trouble getting scipy 0.11 to build on centos and everything appears to be working well with numpy 1.9.2 and scipy 0.15.1. Any thoughts on this?
Pete
On Wed, Apr 1, 2015 at 12:23 PM Stuart Pearce notifications@github.com wrote:
@petercable https://github.com/petercable Good catch. Were you guys trying to integrate the 2015 WMM coefficients when this issue came up? With this bug fix will the 2015-2020 model now be implemented? -Stuart
— Reply to this email directly or view it on GitHub https://github.com/ooici/ion-functions/pull/212#issuecomment-88600956.
cwingard
commented
9 years ago Those module requirements are a hold-over from the previous incarnation. I can't see any reason why we couldn't bump the module versions up since the ion-functions code is now essentially stand-alone.
We should also add the new WMM2015.COF file and update the magnetic declination code to call that file as well. We don't need to update anything else.
Chris
On 4/1/2015 8:21 PM, Pete Cable wrote:
I was trying to create a working install using setup.py and found that no WMM coefficients file was being deployed. I assume the original file was named WMM.COF at some point in time... I don't have any idea if there is any effort to implement a new model (but the code looks like it should support it just fine!)
I had also considered submitting a pull request to soften the module requirements a little by marking versions as >= XX.XX.XX so that we could accept newer versions of packages. I was having trouble getting scipy 0.11 to build on centos and everything appears to be working well with numpy 1.9.2 and scipy 0.15.1. Any thoughts on this?
Pete
On Wed, Apr 1, 2015 at 12:23 PM Stuart Pearce notifications@github.com wrote:
@petercable https://github.com/petercable Good catch. Were you guys trying to integrate the 2015 WMM coefficients when this issue came up? With this bug fix will the 2015-2020 model now be implemented? -Stuart
— Reply to this email directly or view it on GitHub https://github.com/ooici/ion-functions/pull/212#issuecomment-88600956.
— Reply to this email directly or view it on GitHub https://github.com/ooici/ion-functions/pull/212#issuecomment-88620295.
Christopher Wingard
Senior Faculty Research Assistant
Oregon State University
College of Earth, Ocean & Atmospheric Sciences
cwingard@coas.oregonstate.edu
ph: 541.737.0011
Mail/Ship To:
Ocean Observing Center
126 SW McKenzie Avenue
Corvallis, OR 97333
Attn: Christopher Wingard
The set_wmm_model method will select which coefficients file to use (currently only 2010 present), but only a file specifically name WMM.COF will currently be deployed when ion_functions is installed. This change will deploy any coefficient files in the data directory.