ooiepe / epe_modules

1 stars 0 forks source link

EPE-13 Review design of Knowledge Base index and articles #124

Open seagrinch opened 8 years ago

seagrinch commented 8 years ago

Notes from 4/23/15

Knowledge Base Updates

Notes from 1/22/15 Key features of GitHub to replicate:

Other notes from discussion:

seagrinch commented 8 years ago

From Allan on 6/10/16 Ok, this is not very obvious I have to hunt down the code to finally figure out. the kb draggable UI is on each section's landing page /help/cm /help/llb /help/ev /help/db /help/wp

seagrinch commented 8 years ago

From Sage 8/24/16 Looks good. I don’t think there is much to implement here, except some CSS, unless we can also figure out how to get screenshots to align with the steps.

ooi_knowledgebase_list_01 ooi_knowledgebase_detail_01

acyu commented 8 years ago

layout change commit: https://github.com/ooiepe/epe_modules/pull/163

seagrinch commented 8 years ago

There are a number of remaining issues...

  1. First off, while the code worked on my local machine, on our test server I got a syntax error in sites/all/modules/epe_modules/epe_db/epe_db.module on line 128. My guess is that line 139 would also fail. I think this is because we're running PHP 5.3, which I don't think supports the [0] syntax in if(explode('/',$nodeurl)[0] == 'help') {
  2. We should remove the body text on the section index pages. They can just be the list of titles.
  3. How do we update the KB title? (see above)
  4. Can we add breadcrumbs? (see above)
  5. Can we rename the "Common Issues" section? (see above)
  6. Also, how do we tag items to be included in the Common Issues / Getting Started section?
  7. We need to remove the limit of items that are displayed on the main index and section index pages, i.e. all pages should be listed.
  8. Styling needs: section headers, vertical line on index page, page titles, subtitles
  9. I also receive the following errors on the main KB index page or any of the section pages.

Warning: Invalid argument supplied for foreach() in element_children() (line 6541 of /Users/sage/Sites/epe-r3/includes/common.inc). Warning: Illegal string offset '#children' in drupal_render() (line 5998 of /Users/sage/Sites/epe-r3/includes/common.inc). Warning: Illegal string offset '#children' in drupal_render() (line 6008 of /Users/sage/Sites/epe-r3/includes/common.inc). Warning: Illegal string offset '#children' in drupal_render() (line 6046 of /Users/sage/Sites/epe-r3/includes/common.inc). Warning: Illegal string offset '#printed' in drupal_render() (line 6053 of /Users/sage/Sites/epe-r3/includes/common.inc).

seagrinch commented 8 years ago

Still pending...

acyu commented 8 years ago

1, are you referring to section text such as "Placeholder content for the LLB Intro page"? If so, I intentionally left it there because that's actually node body text, and I prefer to edit the page through UI to remove it.

2, the help is the default kb alias that we generated, and it will show all kb page that's tag as kb. is common issue going to have a different tag?

seagrinch commented 8 years ago
acyu commented 7 years ago

I think i got this confused. so we are talking about creating a subpage for common issues, like /help/cm is for concept map, and /help/kb for common issue?

seagrinch commented 7 years ago

Yes, it would be nice to flag a few issues for that category. Otherwise, I'm worried it would just be a random listing, which is why it would be better to have a way to control it.

seagrinch commented 7 years ago

The Common Issues list on the main KB page still lists all kb items, instead of just the ci ones. Also, the section index pages seem to use the same column width as the main index with is two columns. Can they be made full width?

acyu commented 7 years ago

Can you give me a screenshot? because the section index page does stretch to full width

seagrinch commented 7 years ago

It appears to only be the case when you're logged in (or at least when an admin is logged in).

Can you make the section headings match their respective page titles, or is that too tricky?

acyu commented 7 years ago

section heading is essentially page title, I remove the hard coded title, and instead will render what user put in the page title field instead. So, just have to edit the page title of each section page.

the section title on the index page however is still hard coded.