acyu
commented
7 years ago I am not seeing this issue locally, is this still an issue?
Open seagrinch opened 8 years ago
acyu
commented
7 years ago I am not seeing this issue locally, is this still an issue?
Whenever you’re in the Resource Browser, all of the My/Browse links are highlighted in the nav menu. I think this has to do with the fact that I changed the links to relative links so Drupal recognizes all of the links as being the same page. I guess we’ll have to revert to full URLs to prevent this.
From Allan on 5/23/16 https://github.com/ooiepe/epe_modules/pull/100 besides the code merge, additional change to url from Drupal UI is needed. Change all link to relative URL, such as "resource-browser#/search?type=image&filter=author", also, make sure all URL has follow the pattern of "search/?type=?&filter=?"
From Sage on 5/25/16 In general, I think this works well. Except, I think the pulldown and pagination (and sorting) may change the URL structure against the standard listed above so the menu filtering gets confused, so it doesn't work consistently.
From Allan on 5/25/16 Yes, page and sorting does change the url structure, fortunately, the first 2 query string params are consistent, so I can still do partial matching of URL. now if user fuss around with the url structure then yes, my implementation will fail. I am probably implement some sort of query string param comparison that's more precise, I am just not sure if it's worth the effort to perfect it.
From Sage on 5/26/16 After playing with it some more, I think it's the resource type buttons that don't follow the same format.
From Sage on 7/15/16 Allan, I just tested this on production. It seems if you select the "My" links, the browse links are also highlighted. But if you select a browse one, than it's fine.