search

ookii-dialogs / ookii-dialogs-wpf

Awesome dialogs for Windows Desktop applications built with Microsoft .NET (WPF)
BSD 3-Clause "New" or "Revised" License
1.14k stars 85 forks source link

Use Microsoft.Windows.CsWin32 to generate P/Invoke methods #84

Closed virzak closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

augustoproiete commented 2 years ago

Thanks for the PR @virzak ! 👍🏻

Could you create an issue in this repo with the elevator pitch for moving to CsWin32 on this library? I'm definitely not against it, but I'd like to understand the value we get given all the P/Invoke definitions have already been written and have been battle tested for many years.

Also, if we were to go this route, would we be able to use a stable version of the Microsoft.Windows.CsWin32 package directly from the nuget.org feed?

virzak commented 2 years ago

Logged #85.

Yes, the nuget.org version works as well. Something wasn't working during development and I just tried the latest build of the library. Turned out it wasn't at fault. If you'd like I can revert.

virzak commented 2 years ago

Now using the latest version from nuget instead of a private feed.

virzak commented 2 years ago

@augustoproiete, any chance of merging this soon? I'd like to submit another PR which conflicts with this, so if you have a chance to look at this soon, it would avoid future conflict.

augustoproiete commented 2 years ago

@virzak Merged. Sorry for the long delay