search

ookiineko / magiskboot_build

unofficial magiskboot build system (and port) targeting multi-platform (does not require NDK)
Apache License 2.0
129 stars 20 forks source link

Versioned and immutable releases #24

Open kaechele opened 3 months ago

kaechele commented 3 months ago

Right now there is only one release which is also a moving target ("last-ci"), i.e. the "last-ci" tag and release may point to a different commit of the repository at any given time. In order to use magiskboot_build for packaging magiskboot for Linux distributions a tagged and immutable release would be preferable, so that builds can be made against a fixed version. Is this an idea you would be willing to entertain? Alternatively I could resort to using, commit hashes.

ookiineko commented 3 months ago

thanks for reminding! im aware of this problem, the last-ci tag is definitely not intended for distro packagings.

i have been refactoring the code periodically along side with syncing the upstream magiskboot source changes (from its master branch)... now it would require some work to create a versioned tag based on the last stable magisk release (contributions are welcome, idk if im going to do it).

but i think i can add a versioned tag when the next stable magisk release come