Closed krynju closed 8 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
f2f3c1c
) 76.30% compared to head (323fd55
) 76.71%.
Files | Patch % | Lines |
---|---|---|
src/api/src/trace/tracer_provider.jl | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The rationale here is that I could not create Spans with predefined
trace_id
easily. This is to cover the distributed case where I get atrace_id
from an external systemWhen I added the capability to create spans I had to add ways to actually use them, so modified
with_span
etc. a bit. Lots of things were already there, so just filling in the gaps.Also fixes some redefinitions which appear after the schedule Task fix here https://github.com/oolong-dev/OpenTelemetry.jl/pull/97/commits/323fd55d84da28efca87ef6f12983221fa67c888 So it partially fixes https://github.com/oolong-dev/OpenTelemetry.jl/issues/93
Example: