search

oolxg / Hanami

Manga reading app for iOS/iPadOS written with SwiftUI and Composable Architecture
MIT License
174 stars 9 forks source link

Content rating filter not working #6

Open koinsj opened 1 year ago

koinsj commented 1 year ago

I unticked all the content rating filter options then started sniffing and searched for some random stuff, the url was like this: https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc

Then I only ticked the safe option and did the search again, this time the url was like this: https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc&contentRating%5B%5D=safe

I noticed that the filter option was added to the end of the url, but other options like suggestive and erotica were still present in the url. I guess that’s why I could still see those results even if I only ticked the safe option.

Sorry if my English is a bit poor.

koinsj commented 1 year ago

Thank you for the update! But I'm afraid there has been a misunderstanding. I was not saying that you could enable other content ratings along with the ‘safe’. What I meant was the contentRating in the mangadex api url wasn’t updated properly.

When all content ratings were disabled, these sections were still in the api url: contentRating[]=safe&contentRating[]=suggestive&contentRating[]=erotica

And when all content ratings were enabled, other contentRating sections were added to the end of the api url: contentRating[]=erotica&contentRating[]=pornographic&contentRating[]=safe&contentRating[]=suggestive

That made the whole api url look like this: https://api.mangadex.org/manga?title=Random&limit=10&offset=0&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive&contentRating%5B%5D=erotica&includes%5B%5D=cover_art&includes%5B%5D=author&order%5Brelevance%5D=desc&contentRating%5B%5D=erotica&contentRating%5B%5D=pornographic&contentRating%5B%5D=safe&contentRating%5B%5D=suggestive

‘safe’, ‘suggestive’ and ‘erotica’ were repeated in the url, so they would keep showing in the search result no matter you enabled them or not.

(By the way, I feel that ‘safe’ and other ratings should be able to be chosen at the same time in case someone wants to see all results. )