search

oom-is / sedutil

DTA sedutil Self encrypting drive software
3 stars 1 forks source link

Bug: --enableUser is implemented but not included in usage note #16

Closed oom-is closed 5 years ago

oom-is commented 5 years ago

The command-line option to sedutil-cli for --enableUser is fully implemented, and appears in the Wiki pages, but doesn't show up when the "usage" info is displayed (e.g. sedutil-cli with no further arguments). File to be fixed is Common/DtaOptions.cpp

Further, just in case anyone looks closely: There's a bug later in the same file where the prototype claims there are only two arguments but then lists three.
BEGIN_OPTION(enableuser, 2) OPTION_IS(password) OPTION_IS(userid) OPTION_IS(device) END_OPTION (that "2" above should be "3"

This was (correctly but silently) fixed by @CyrilVanErsche as part of his pull request #272 so anyone who wants to use that function but hasn't ingested that CVE pull request needs to fix the number of arguments. Realistically, though, anyone using Opal who wants to use --enableUser probably also wants to include the AddUserToLockingACEs functionality, so it's not clear who would care strongly about a separate fix for the number-of-arguments bug...

oom-is commented 5 years ago

Closing - this has been added to the "QOL-typo-fixes" branch here - although I'm treating it as a bug, I can't make that determination for upstream. It's also in updated Pull Request #307.

This is being integrated into the integ branch along with all other changes.