search

oomek / attractplus

Attract-Mode Plus
GNU General Public License v3.0
46 stars 16 forks source link

Update msg_template.txt with missing strings #52

Open Ro-Borges opened 1 year ago

Ro-Borges commented 1 year ago

Update the msg_template.txt with all the missing strings I could find so far

oomek commented 1 year ago

There are some entries i your commit that don't exist in the source code Down (Next Game) Left (Previous Display) Right (Next Display) Up (Previous Game)

Additionaly I've realised that many _help strings aren't even used. There is a long way ahead of us if we want to clean it all up.

Ro-Borges commented 1 year ago

There are some entries i your commit that don't exist in the source code Down (Next Game) Left (Previous Display) Right (Next Display) Up (Previous Game)

Additionaly I've realised that many _help strings aren't even used. There is a long way ahead of us if we want to clean it all up.

They are used in the controls option from the main menu and get translated if added to a language file.

My next "job" would be to go through the help messages used and then compare with the ones in the source file

image

image

oomek commented 1 year ago

These 5 entries are dynamically constructed from the navigation direction and default action configured inside each direction entry. For example Up and Previous Game which are already in the translation files. image

If these are present in some of the translation files that means someone has put them there by mistake.

oomek commented 1 year ago

https://github.com/oomek/attractplus/blob/63b68c004b2fc5be0828c6e3b88a1961b029072b/src/fe_config.cpp#L1655

Ro-Borges commented 1 year ago

I get it, but even if there is a translation for the individual words, the dinamically combined words don't get translated.

That is why I had to put them in the template

oomek commented 1 year ago

You are right. You have just discovered a bug. This should not be like that, because having to provide 39 translations for each of 5 compound controls sounds a bit insane. I'll look into it.

oomek commented 1 year ago

Issue fixed in https://github.com/oomek/attractplus/commit/a8ad0fb1e4dc721e2bc5be1f2369b9dfd7a8f456 You can now push more commits to this PR consisting only of basic strings.

pedrowarlock commented 8 months ago

Sorry to intrude, but they are two different strings: You cannot replace one with the other, but add the new one without the "?"

image

image