hellais
commented
1 year ago We noticed on 20th of July that we had not in fact flagged the measurements prior to shipping this backend version to be as failed as can be seen by this query:
SELECT
engine_version,
COUNT()
FROM fastpath
WHERE (test_name = 'signal') AND (measurement_start_time > '2023-05-05') AND (msm_failure = 'f')
GROUP BY engine_version
ORDER BY engine_version ASC
Query id: f0e7a699-efee-4ca8-94d3-1715b33bc056
┌─engine_version─┬─count()─┐
│ 3.16.5 │ 8190 │
│ 3.16.6 │ 2681 │
│ 3.16.7 │ 46664 │
│ 3.17.0 │ 246 │
│ 3.17.1 │ 150166 │
│ 3.17.2 │ 344786 │
│ 3.17.3 │ 133 │
│ 3.17.4 │ 591 │
│ 3.17.5 │ 12765 │
│ 3.18.0 │ 403 │
│ 3.18.0-alpha │ 117 │
│ 3.18.1 │ 134 │
│ 3.19.0-alpha │ 170 │
└────────────────┴─────────┘All measurements with these engine versions and measurement_start_time > 2023-05-05 should be marked as failed:
┌─engine_version─┬─count()─┐
│ 3.16.5 │ 8190 │
│ 3.16.6 │ 2681 │
│ 3.16.7 │ 46664 │
│ 3.17.0 │ 246 │
│ 3.17.1 │ 150166 │
FedericoCeratto
We should mark all measurements from signal test coming from engine_version < 3.17.2 and with measurement_start_time > 2023-05-02 as failed.
See also: https://github.com/ooni/probe/issues/2477