codecov[bot]
commented
6 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
6258173) to head (ff33685). Report is 1 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #831 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 21 21 Lines 1448 1448 Branches 116 116 ========================================= Hits 1448 1448 ``` | [Flag](https://app.codecov.io/gh/ooni/backend/pull/831/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | Coverage Δ | | |---|---|---| | [ooniauth](https://app.codecov.io/gh/ooni/backend/pull/831/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | `100.00% <ø> (ø)` | | | [oonirun](https://app.codecov.io/gh/ooni/backend/pull/831/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The https://github.com/ooni/probe-cli/pull/1421 PR trimmed the endpoints and bumped signal's version to v0.2.5.
So we need to ignore versions of signal lower than v0.2.5.
I am wondering whether we should also use a time window because otherwise what happens when we reprocess measurements. If my analysis is correct, then we have an additional issue that there's another check in this codepath that seems to mark signal measurements as failed without any temporal constraints. This would also cause reprocessing to cause downstream issues.
Part of https://github.com/ooni/probe/issues/2636