search

ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

feat: generate dnscheck observations #2

Closed hellais closed 2 years ago

hellais commented 2 years ago

Add support for generating observations for DNS check.

As part of this PR I have also made some smaller improvements to ooni/data overall, which includes:

Nice things to have that are currently missing are:

Open questions/things to figure out:

Closes https://github.com/ooni/backend/issues/606

bassosimone commented 2 years ago

@hellais regarding your open questions:

Nice things to have that are currently missing are:

  • Supporting extracting metadata from the network_events specific to dnscheck, for example the DNS lookup time (though this could eventually become part of the base formats too)

We can do this later

Open questions/things to figure out:

  • Do we need any additional metadata inside of the tables to make the task of analysing these results easier?

Unclear. Let me use this a bit and then I'll get back to you with more feature requests and feedback.

To be clear: I suggest to merge this now and any follow-up change can be a subsequent PR.

hellais commented 2 years ago

Thanks for the review. I have implemented your suggestions in this PR.