ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

New proposal for instant experiment result data model #43

Closed hellais closed 6 months ago

hellais commented 9 months ago

This implements: https://github.com/ooni/data/issues/42

codecov[bot] commented 9 months ago

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (cb4eebd) 76.12% compared to head (6f628df) 80.92%.

:exclamation: Current head 6f628df differs from pull request most recent head 829a17b. Consider uploading reports for the commit 829a17b to get more accurate results

Files Patch % Lines
oonidata/analysis/website_experiment_results.py 77.14% 109 Missing :warning:
oonidata/dataviz/web.py 0.00% 31 Missing :warning:
oonidata/models/observations.py 9.09% 10 Missing :warning:
oonidata/workers/analysis.py 92.92% 7 Missing :warning:
oonidata/analysis/web_analysis.py 80.95% 4 Missing :warning:
oonidata/datautils.py 33.33% 2 Missing :warning:
oonidata/models/experiment_result.py 95.23% 2 Missing :warning:
oonidata/cli/command.py 80.00% 1 Missing :warning:
oonidata/db/connections.py 50.00% 1 Missing :warning:
...ata/transforms/nettests/measurement_transformer.py 80.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== + Coverage 76.12% 80.92% +4.80% ========================================== Files 69 69 Lines 5989 6067 +78 ========================================== + Hits 4559 4910 +351 + Misses 1430 1157 -273 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hellais commented 9 months ago

Once ooni/data#44 is landed in here. I should be sure to merge this without squashing everything compacting all the above commits into one.

For the rationale behind this decision see this comment: https://github.com/ooni/data/pull/44#issuecomment-1820464447

hellais commented 9 months ago

The git history is now clean. This branch is ready for review.

hellais commented 6 months ago

I am going to land this into main to make progress on shipping this.