search

ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

feat: introduce support for generating observations for circumvention nettests #48

Open DecFox opened 9 months ago

DecFox commented 9 months ago
hellais commented 9 months ago

This looks really good, thanks for working on it!

Could you perhaps split this PR up into two, where you keep the stuff which adds new Observation data models (the one about circumvention tools) so that we can land the facebook_messenger observation generation sooner?

I think the new Observation tables for circumvention tools we should take a bit more time to think if this approach is solid (which it might very well be) and I would not want that to stall on landing the facebook_messenger transformer which is much more straightforward.