search

ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

feat: introduce observation generation for stunreachability, urlgetter, browser_web #50

Closed DecFox closed 7 months ago

DecFox commented 8 months ago

This diff introduces observation generation support for stun_reachability, urlgetter and browser_web nettests.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aa43cd0) 76.48% compared to head (eeff0ea) 76.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================== + Coverage 76.48% 76.58% +0.09% ========================================== Files 72 78 +6 Lines 6091 6226 +135 ========================================== + Hits 4659 4768 +109 - Misses 1432 1458 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hellais commented 7 months ago

I think I broke the tests as part of the merge commit.

@DecFox can you look into fixing the tests?

I can otherwise look at fixing this either later today or early next week.

DecFox commented 7 months ago

Pushed the fixes. Tests are passing now.