ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

Properly handle ctrl-c termination of workers #67

Closed hellais closed 3 months ago

hellais commented 6 months ago

Currently the workers for oonipipeline spawn a series of processes that then run async work inside of a set of worker threads.

For some reason getting them to nicely handle SIGINT is not easy. I spent some time debugging it, but still things were not working nicely. It might be due to some bugs or inconsistencies in signal handling in python and async.

I am leaving here some of the links I read while debugging this:

hellais commented 3 months ago

This is fixed in https://github.com/ooni/data/pull/81