search

ooni / data

OONI Data CLI and Pipeline v5
https://docs.ooni.org/data
8 stars 4 forks source link

Add support for temporal cloud #79

Closed hellais closed 3 months ago

hellais commented 3 months ago

Changes:

This fixes:

As part of this I am doing also a bit of refactoring of the temporal related code to make this easier.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.45045% with 109 lines in your changes missing coverage. Please review.

Project coverage is 82.08%. Comparing base (85652ec) to head (e14cb97).

Files Patch % Lines
...ine/src/oonipipeline/temporal/client_operations.py 63.93% 66 Missing :warning:
...onipipeline/src/oonipipeline/temporal/workflows.py 66.17% 23 Missing :warning:
oonipipeline/src/oonipipeline/cli/commands.py 90.10% 9 Missing :warning:
...ine/src/oonipipeline/temporal/activities/common.py 75.86% 7 Missing :warning:
oonipipeline/src/oonipipeline/db/create_tables.py 60.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================== + Coverage 77.41% 82.08% +4.66% ========================================== Files 32 75 +43 Lines 1913 6295 +4382 ========================================== + Hits 1481 5167 +3686 - Misses 432 1128 +696 ``` | [Flag](https://app.codecov.io/gh/ooni/data/pull/79/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | Coverage Δ | | |---|---|---| | [oonidata](https://app.codecov.io/gh/ooni/data/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | `77.41% <ø> (ø)` | | | [oonipipeline](https://app.codecov.io/gh/ooni/data/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni) | `84.11% <75.45%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ooni#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hellais commented 3 months ago

The tests are green and I am already running this on the data.ooni.org host. I am going to proceed with merging it.

(the red is only the codecov complaining, but the pieces of impacted code are really hard to test, so I am tabling this for the moment)