hellais
commented
3 months ago This looks good. I left two small comments. I guess my only question is if we want to do something to improve the amount of code re-used between the oonith-service and the ooniapi-service modules.
There are tradeoffs to each. On the one hand if we reuse some of the code it's less code to maintain, OTOH, we compromise some flexibility in being able to independently tweak the building and deployment configs of each without worrying about interdependencies.
For this reason I think the approach of just duplicating most of the code as a starting point is more reasonable. We can at some point in the future do some refactoring to maximise code re-use, but it would be wise to do that only once we have more clear how to generalize in a way that we aren't tying our hands too much.
github-actions[bot]
This diff creates the
oonith_serviceandoonith_service_deployerand makes use of these to deploy theoohelperdservice. Final step in #29