Closed hellais closed 5 years ago
Some notes from my 1:1 discussion with @sarathms on 09 Nov 2018 based on the following state of measurement header
Related to https://github.com/ooni/explorer/issues/2
@sarathms quick feedback from my end:
First off, in the mockups we have a wider body width, whereas in the implementation it's very narrow. Could you refer to the mockups layout width for that?
Related to the first point, many font sizes are off as well: The header values are currently 24px but should be 28px. The headings in Other Details
or Raw Measurement Data
are also 22px but should be 24px. Also the value font size in the "Other Details" section is 16px but should be 18px. Same gooes to the description above which overflows which should be 28px and not 16px.
The tick icon for Reachable
is not the one we use. Let me know if you have trouble getting that icon.
The test class and test name are in black, while the test class should be in white, with the container in the test class color and the test name in the same color.
Below that, the text seems to be overflowing. This also happens in the Raw Measurement Data field. The data should have its own scrollbar instead of changing the whole webpage's width. Here is the screenshot of the whole page how it looks on my latest Firefox:
The DOWNLOAD JSON
button should be in Title Case instead, so Download JSON
. Also it's currently 11px while in the mockups it's 20px.
In the Other Details
field could you give some more space between the rows/ raise the line height? Also the padding to the top of the box background should be reduced a little bit (refer to mockups)
All over there are many things which can be answered by the mockups if you use their values as a reference. Happy to jump on a 1:1 as well to go through these. Thanks for the quick progress so far!
We finished a first iteration of this that implements views for all the tests.
Here is, as a reference, links to some measurement pages:
@elioqoshi could your feedback into other individual tickets so we can move it forward from there?
I suggest we implement those as a next iteration.
Feedback continuing here: https://github.com/ooni/explorer/issues/35
Link to mockup
Every measurement type needs to have a view showing the results in OONI Explorer.
The pattern to follow here, I think, could be similar to that taken for probe-desktop.
See: https://github.com/ooni/probe-desktop/tree/master/renderer/components/nettests
In particular we need a view for:
For each of these measurement types, it's important to take into account the possible values the relevant
test_keys
will take.To learn more about the data format of the test_keys, check out the test specifications: https://github.com/ooni/spec/tree/master/test-specs