search

ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
71 stars 37 forks source link

Fix text on WhatsApp measurement page when it's blocked #753

Closed majakomel closed 2 years ago

majakomel commented 2 years ago

I used a similar logic to how determining anomaly is done for Signal and some other messaging components, the rest seems to work correctly now.

Closes https://github.com/ooni/explorer/issues/660

vercel[bot] commented 2 years ago

@majakomel is attempting to deploy a commit to the OONI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
explorer ✅ Ready (Inspect) Visit Preview May 4, 2022 at 2:11PM (UTC)
sarathms commented 2 years ago

Thanks @majakomel for looking into this. In general, we have been trying to move away from the approach of Explorer trying to determine the OK/Anomaly status of a measurement by looking into the test_keys and instead let the backend determine this. It is true that we still do this in some cases, but the idea is to eventually not do those either.

For this particular case, issue there is a backend issue (ooni/backend#559) that when addressed should fix this issue without any changes to Explorer. It should have been documented in the issue this PR intends to address. Sorry about that.