search

ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
71 stars 37 forks source link

Domain field only searches domains but not resolved IP Addresses #775

Open besendorf opened 2 years ago

besendorf commented 2 years ago

Expected Behavior

I expected the domain field to also search for resolved IP Addresses. As the field says domain or IP address. However it does not. I guess it might find IP Addresses when you enter a IP address as a test target, but I couldn't find an example. I think it would be quite helpful to also search the resolved IP Addresses to better search for IP based blocking and for example to verify that an IP is blocked in a country or AS.

Actual Behavior

Only searches for domains

Steps to Reproduce the Problem

example test: https://explorer.ooni.org/measurement/20220801T235930Z_webconnectivity_US_7018_n1_ZYzC9xGkRrhZZKho?input=https%3A%2F%2Fapps.crowdtangle.com%2Fpublic-hub%2Fcovid19 example search with an IP from that test: https://explorer.ooni.org/search?test_name=web_connectivity&failure=true&since=2022-08-01&until=2022-08-02&domain=52.42.211.177

hellais commented 1 year ago

Currently the domain filter applies to IPs only if the target for testing was specified as a URL containing an IP instead of a domain name (ex. https://8.8.8.8/).

Supporting searching through measurements by filtering on the DNS resolutions is a pretty major backend change.

I think in the interim, we might want to improve the UX of the search filter to clarify what we mean by IP in that context.