search

ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
71 stars 37 forks source link

inconsistent handling of duplicated search parameter #786

Open ainghazal opened 2 years ago

ainghazal commented 2 years ago

Expected Behavior

For duplicated parameters, I expect repeated parameters to be either ignored or yuxtaposed. The UI seems to indicate that (at least for the domain parameter) they are being added.

Actual Behavior

More than one parameters (in the case of domain, at least) result in a wildcard query.

Steps to Reproduce the Problem

  1. Open https://explorer.ooni.org/search?since=2022-07-17&until=2022-08-17&failure=true&probe_cc=IR&test_name=web_connectivity&domain=www.facebook.com&domain=www.example.com&probe_asn=AS197207 (duplicated domain) or https://explorer.ooni.org/search?since=2022-07-17&until=2022-08-17&failure=false&test_name=web_connectivity&domain=www.facebook.com&probe_cc=IR&probe_asn=58224&probe_asn=31549 (duplicated asn)
  2. Observe that the filter by domain or ans is not taken into account.
hellais commented 1 year ago

Eventually once we support multiple query values for a filter (see: https://github.com/ooni/explorer/issues/812 & https://github.com/ooni/backend/issues/584) we can maybe rewrite the address bar to filter by multiple domains