search

ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
71 stars 38 forks source link

adding git inside the container #806

Closed GermaVinsmoke closed 1 year ago

GermaVinsmoke commented 1 year ago

Signed-off-by: GermaVinsmoke vaibhav1180@gmail.com

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
explorer ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 5:58AM (UTC)
majakomel commented 1 year ago

Just adding git is unfortunately not going to be enough with our current build process - there are other changes needed in the build script we use. I'm working on other build improvements here (still WIP) https://github.com/ooni/explorer/pull/808

GermaVinsmoke commented 1 year ago

But when I tested with the current DockerFile, it was giving git not found. On installing git inside the builder container, it was able to run those yarn --silent commands successfully 🤔

majakomel commented 1 year ago

Yes, we need to add git, but it is not the only thing required for it to work, since we currently run it against git archive, which is "not a git repository" (doesn't contain .git folder). I also found out there are some other optimizations we can do to drastically decrease docker image size.

GermaVinsmoke commented 1 year ago

That means, even the previous ./git-populate-env.sh script was wrong for populating the git env variables 🤔 Then, in that case, I think I can close this PR.

majakomel commented 1 year ago

Closing this since it's included in https://github.com/ooni/explorer/pull/808