search

ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
71 stars 38 forks source link

DNS Answers: Add columns for AS number and ISP name #827

Closed sleinen closed 1 year ago

sleinen commented 1 year ago

The measurement JSON may include additional information about IP addresses returned in DNS answers. In particular, the "asn" field contains the AS (Autonomous System) number advertising the IP address, and "as_org_name" the organizational name for that AS/ISP.

This change adds these fields to the answer table as two additional columns.

I'm not sure this is the best way to present this information, but it fulfils the feature request and works even when the additional fields are missing. In this case the values in the new columns will simply be empty.

Closes #821

vercel[bot] commented 1 year ago

@sleinen is attempting to deploy a commit to the OONI Team on Vercel.

A member of the Team first needs to authorize it.

sleinen commented 1 year ago

Upon further reflection, I'm not sure whether this change introduces a security risk: The additional fields in the DNS Answer part of the measurement JSON might contain untrustworthy information. In particular, an evil actor could try to put HTML code in as_org_name via some routing registry to attack the browser of someone viewing an OONI test result. So we should make sure these strings get properly escaped. Unfortunately I'm neither familiar with the UI framework (React) nor with the way the JSON data is filled in. Guidance welcome!

sleinen commented 1 year ago

Abandoned in favor of #828