ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
64 stars 37 forks source link

Website Categoires are shown not in alphabetical order in the filters section and on the dashboard of OONI MAT #848

Closed sloncocs closed 1 year ago

sloncocs commented 1 year ago

Expected Behavior

The list of website categories should be similarly structured in alphabetical order in all interfaces.

Actual Behavior

In the Filters section and in the dashboard, the 'Social Networking' and 'Terrorism and Militants' categories are in the wrong places.

Screenshot 2023-03-21 at 14 52 27 Screenshot 2023-03-21 at 14 52 38

Steps to Reproduce the Problem

  1. Set 'Rows' to 'Websites Categories'
  2. Scroll the Filters section to find 'Social Networking' and and 'Terrorism and Militants'
  3. Scroll the dashboard to find 'Social Networking' and 'Terrorism and Militants'

Specifications

NA

chidexebere commented 1 year ago

A little investigation shows that the category code was used to query the actual category, filter and sort as shown below.

MAT-data

The category codes for 'Social Networking' and 'Terrorism and Militants' are GRP and MILX respectively which do not closely follow like others. For example:

This issue also affects categories like 'E-commerce' and 'Media sharing' because their category codes are COMM and MMED respectively.

A better solution will be to make the changes to the category codes in the OONI API but this will require the core team because there might be reasons why these conventions were used.

If for some reason these codes can not be easily changed, the sorting algorithm might have to be changed.

TL;DR: input from the core team is needed.