ooni / explorer

OONI Explorer: uncover evidence of internet censorship worldwide
https://explorer.ooni.org
BSD 3-Clause "New" or "Revised" License
64 stars 37 forks source link

TCP Connect section of web connectivity measurement page should just state the outcome #900

Closed hellais closed 4 months ago

hellais commented 5 months ago

Currently the TCP connect section makes some amount of "analysis" inside of the measurement page, which should not be the responsibility of OONI Explorer.

We should instead just list the reason why a connection failed or didn't fail in there, by listing the outcome of the failure field.

hellais commented 4 months ago

This is a requirement for shipping web connectivity 0.5, so I'm bumping up the priority.

I suggest we extract the failure reason and print that if present, instead of using the value of the blocked key.

See also: https://github.com/ooni/probe/issues/2687