feat: improve robustness of extras/pinger

ooni / minivpn

A minimalistic OpenVPN implementation in Go

GNU General Public License v3.0

38 stars 6 forks source link

feat: improve robustness of extras/pinger #12

Closed ainghazal closed 2 years ago

ainghazal commented 2 years ago

refactor pinger to use a modification of go-ping
re-introduce passing of context to client/muxer

ainghazal commented 2 years ago

The TL;DR of my perplexity is that, if you do:

I see your point! I think this was only working because the pinger implements the exponential backoff so the chance to check for an expired ctx was within the order of magnitude of the expected timeouts. so you're basically suggesting to have a context-aware select in the low-leve read method am I correct?