search

ooni / minivpn

A minimalistic OpenVPN implementation in Go
GNU General Public License v3.0
38 stars 6 forks source link

make sure that pinger returns stats even when there's packet loss #19

Closed ainghazal closed 2 years ago

ainghazal commented 2 years ago

this issue might belongs to probe-cli, but I'm keeping track of it here since that functionality is not yet merged.

it's not clear to me if this is bad error handling on the side of the nettest, or an issue with how pinger handles context cancellation.

ainghazal commented 2 years ago

I'm fixing this on the side of probe-cli, it turned out to be just that I was missing calling the Stats() method when a failure occurred.