search

ooni / minivpn

A minimalistic OpenVPN implementation in Go
GNU General Public License v3.0
38 stars 6 forks source link

refactor: changes after code review #5

Closed bassosimone closed 2 years ago

bassosimone commented 2 years ago

We're performing a code review of this repository before writing a new OONI experiment that depends on it.

In this first round of code review, I:

  1. fixed all linter warnings in the vpn package;

  2. reviewed vpn/bytes.go and vpn/ciphers.go applying minimal transformations to increase code quality and adding TODO comments identifying aspects to be discussed with @ainghazal.

See https://github.com/ooni/probe/issues/2083.

ainghazal commented 2 years ago

rebased & merged into main; I think I've addressed all comments so far.

bassosimone commented 2 years ago

Closing because code has been merged without using a pull request, thanks!