ainghazal commented 6 months ago

Checklist

[x] I have read the contribution guidelines
[x] Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
[x] Reference issue for this pull request: #47

Description

In this PR I implement the reliability algorithm for the OpenVPN protocol:

Each reliable packet emitted is subject to retransmission if it's not acked in time. Retransmission follows an exponential backoff - beginning at 2 seconds, with a cap at 60s.
Incoming packets are subject to reordering before being passed to TLS.
Incoming packets are passed to reliable.moveDownWorker to send ACKs if there's a packet in the outgoing queue.

ainghazal commented 6 months ago

Removing "wip" label, I think this PR is ready for review. @bassosimone let me know if you prefer that I extract the cmd/entrypoint I used for testing into a different PR.

bassosimone commented 5 months ago

@ainghazal for some reason, tests are not running. Do you mind checking why?

ainghazal commented 5 months ago

@bassosimone enabled in https://github.com/ooni/minivpn/pull/61

ooni / minivpn

feat: implement reliable transport #57

Checklist

Description