ooni / minivpn

A minimalistic OpenVPN implementation in Go

GNU General Public License v3.0

36 stars 6 forks source link

Closed ainghazal closed 4 months ago

ainghazal commented 5 months ago

Expose config and tunnel as a public API.

This refactor tries to expose all the useful functions to instantiate an OpenVPN tunnel (paving the way to usage from probe-cli).

Checklist

[x] I have read the contribution guidelines
[x] Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
[x] Reference issue for this pull request:

ainghazal commented 5 months ago

Deferring review until we merge #68 (which is included in this branch right now).

ainghazal commented 4 months ago

The only question I have is why the logger_test and tracer_test were removed? Is it because this new layout makes testing of those packages harder?

it was a bit of a cleanup:

logger_test was providing a test logger for other tests to use; this was moved to model.mocks.TestLogger
similarly, tracer_test provided only a no-op implementation of model.HandshakeTracer; I decided that I can pass model.DummyTracer to all tests that need to receive a tracer.