search

ooni / probe-engine

Semi-automatic export of https://github.com/ooni/probe-cli internals
https://ooni.org
GNU General Public License v3.0
45 stars 16 forks source link

netx: merge with github.com/ooni/probe-engine #357

Closed bassosimone closed 4 years ago

bassosimone commented 4 years ago

Same argument as for https://github.com/ooni/probe-engine/issues/356. Specifically, jafar is the other consumer of netx. Maybe by moving everything inside here we can also consolidate the integration tests that we run, and we can run integration testing of netx directly? Also: when investigsting https://github.com/ooni/probe-engine/issues/355, I noticed that there is opportunity for radically simplifying netx in a bunch of places, without necessarily gutting its external API. This can be more easily done inside the same repository when we can check for API breakages immediately. (For the records, this move has been suggested to me by @FedericoCeratto some time ago, but I didn't feel like changing what was working until that become an issue preventing me/us from moving faster, which I currently think is becoming the case.)

bassosimone commented 4 years ago

This has been done in https://github.com/ooni/probe-engine/pull/380. No time estimate because we've done it as part of https://github.com/ooni/probe-engine/issues/302.