ooni / probe-engine

Semi-automatic export of https://github.com/ooni/probe-cli internals
https://ooni.org
GNU General Public License v3.0
45 stars 16 forks source link

Netx research and refactoring in Sprint 11 #509

Closed bassosimone closed 4 years ago

bassosimone commented 4 years ago

The generic idea is that what ends up in the netx folder is the more complex implementation and the simpler implementation will be instead inside of internal. The main objective of this effort is to understand whether we can use the decorator pattern based technique also for collecting measurements. I think so, but it's better to be sure about this by changing Psiphon and evaluating whether this is really an improvement.

If all is good, we will have significantly simplified netx implementation and testability in a few sprints. If there are emerging issues, then it means we need to somehow change the plan again.

bassosimone commented 4 years ago

Done a bunch of work here and created followup as https://github.com/ooni/probe-engine/issues/543.