Not uploaded icon missing from result list view

[hellais]

The first result set has not been uploaded yet in the result view we don't see the missing upload icon:

We do see it, though, when we enter the measurement itself:

It's unclear if this needs to be fixed in probe-desktop, probe-cli or both.

[hellais]

This is missing inside of probe-cli

[sarathms]

Is this now implemented in probe-cli?

[hellais]

Unfortunately not yet

[hellais]

@sarathms I checked and it was actually already present in probe-cli. Reassigning this to you.

[sarathms]

@hellais This is one of the items in the output from ooniprobe list --batch

{
  "fields": {
    [redacted],
    "data_usage_down": 21.9140625,
    "data_usage_up": 5.5576171875,
    "id": 21,
    "index": 15,
    "is_done": true,
    "measurement_anomaly_count": 0,
    "measurement_count": 3,
    "name": "im",
    [redacted]
    "runtime": 0,
    "start_time": "2021-03-25T16:13:27.588048991Z",
    "test_keys": "{}",
    "total_count": 16,
    "type": "result_item"
  },
  "level": "info",
  "timestamp": "2021-03-25T15:42:00.200596637-04:00",
  "message": "result item"
}

It doesn't indicate whether the measurements were uploaded or not. This particular result has measurements which are not uploaded as shown in ooniprobe list 21 --batch

  "fields": {
    [redacted],
    "failure_msg": "",
    "id": 42,
    "is_anomaly": false,
    "is_done": true,
    "is_failed": false,
    "is_first": true,
    "is_last": false,
    "is_upload_failed": false,
    "is_uploaded": false,
    [redacted],
    "report_file_path": "",
    "runtime": 0.303577437,
    "start_time": "2021-03-25T16:13:27.602353155Z",
    "test_group_name": "im",
    "test_keys": "{\"facebook_dns_blocking\":false,\"facebook_tcp_blocking\":false}",
    "test_name": "facebook_messenger",
    "type": "measurement_item",
    "upload_failure_msg": "",
    "url": "",
    "url_category_code": "",
    "url_country_code": ""
  },

[hellais]

Yes you are right, this is not currently present inside of probe-cli. We need to add support for it in probe-cli before we can implement it inside of the desktop app.

I documented that this needs to be done as part of: https://github.com/ooni/probe/issues/1457

[hellais]

This is now implemented in probe-cli