search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
749 stars 142 forks source link

riseupvpn: handshake using obfs4 #1463

Open bassosimone opened 3 years ago

cyBerta commented 3 years ago

Hey @bassosimone,

I'm wondering what the current state of obfs4 support in ooni is. From what I understood so far (I didn't check the repository , commits etc. for a while) from the community meeting, there's no foundational work done yet as part of the tor test improvements. Is this right?

bassosimone commented 3 years ago

Good day @cyBerta!

So, regarding your question, we do have support for obfs4: the code is in ./internal/engine /legacy. That part of code is marked as a legacy because it's still using the initial design for netx, which was more complex than the new design and a bit difficult to maintain.

I have had eyes on refactoring just that chunk that I linked to and move it into the netx/dialer so that riseupvpn could import it. I have not been too worried about keeping this legacy part for some time, though, because the code is working fine and maintenance is what is difficult. So, I imagined that with us making progress on integrating Snowflake, I would have also moved the obfs4 code.

Since I have been a bit overworked recently, it would be actually great if you could help out in this department! I would really appreciate it! Thank you for your interest in this issue :-)

cyBerta commented 3 years ago

Thanks for the update here: https://github.com/ooni/probe/issues/1605. I have it on my list, but it might take a while until this task becomes my priority. On the other hand I think this ticket doesn't block any other development, right?

bassosimone commented 3 years ago

Correct, nothing is currently blocking on it!