search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
758 stars 142 forks source link

experiment: remove code to submit measurements #1508

Open bassosimone opened 4 years ago

bassosimone commented 4 years ago

Working on https://github.com/ooni/probe-engine/issues/893, I ended up making a more robust API for submitting measurements where we can basically pass it measurements and they will be submitted. The original OONI had a similar design, while the current design is more inspired to MK, where we could do less because C++ is hard.

So, it seems that now we have again this nice submitting capability and we probably don't need to have special purpose more limited code for doing the same inside the implementation of each experiment. Of course, if we are to remove such code, we need first to make sure that the places where we use it (miniooni, probe-cli) migrate to the new API.

bassosimone commented 3 years ago

Started working on this issue in Sprint 30. We have a prototype but we're not ready to merge yet. We will continue discussing. In any case, the initial prototype does not fully address the issue but just starts addressing it.