ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
760 stars 142 forks source link

Improve code coverage #1541

Open bassosimone opened 3 years ago

bassosimone commented 3 years ago

The following are all the packages with code coverage < 100%. We should take a look and see if we can possibly improve the coverage for some of these modules. We should aim to have at least 90% for each of the modules below.

?       github.com/ooni/probe-engine/cmd/miniooni   [no test files]
ok      github.com/ooni/probe-engine/cmd/oohelperd  0.115s  coverage: 61.9% of statements
ok      github.com/ooni/probe-engine/experiment/ndt7    38.070s coverage: 99.5% of statements
ok      github.com/ooni/probe-engine/experiment/riseupvpn   18.152s coverage: 93.1% of statements
ok      github.com/ooni/probe-engine/experiment/sniblocking 1.953s  coverage: 98.9% of statements
?       github.com/ooni/probe-engine/internal/httpfailure   [no test files]
?       github.com/ooni/probe-engine/internal/httpheader    [no test files]
ok      github.com/ooni/probe-engine/internal/mlablocatev2  0.580s  coverage: 97.6% of statements
?       github.com/ooni/probe-engine/internal/mockable  [no test files]
ok      github.com/ooni/probe-engine/internal/platform  0.028s  coverage: 91.7% of statements
ok      github.com/ooni/probe-engine/internal/sessionresolver   1.356s  coverage: 95.2% of statements
ok      github.com/ooni/probe-engine/internal/torx  0.043s  coverage: 92.9% of statements
ok      github.com/ooni/probe-engine/legacy/netx    1.977s  coverage: 98.0% of statements
ok      github.com/ooni/probe-engine/legacy/oonidatamodel   0.051s  coverage: 97.6% of statements
ok      github.com/ooni/probe-engine/libminiooni    27.854s coverage: 77.6% of statements
ok      github.com/ooni/probe-engine/netx/dialer    3.172s  coverage: 99.5% of statements
ok      github.com/ooni/probe-engine/netx/errorx    0.116s  coverage: 91.7% of statements
?       github.com/ooni/probe-engine/netx/gocertifi [no test files]
ok      github.com/ooni/probe-engine/netx/httptransport 0.660s  coverage: 92.5% of statements
ok      github.com/ooni/probe-engine/netx/trace 0.032s  coverage: 44.4% of statements
ok      github.com/ooni/probe-engine/oonimkall/tasks    65.222s coverage: 99.3% of statements
?       github.com/ooni/probe-engine/probeservices/testorchestra    [no test files]
?       github.com/ooni/probe-engine/version    [no test files]

Run used to generate the full coverage: https://github.com/ooni/probe-engine/runs/1691028481

bassosimone commented 3 years ago

Moving to Sprint 32.