ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
766 stars 142 forks source link

sessionresolver: we can re-enable dns.google DoH HTTP3 resolutions #1883

Closed bassosimone closed 2 years ago

bassosimone commented 3 years ago

This issue is about adding again support for performing DNS resolutions over HTTP3 in the sessionresolver package of ooni/probe-cli.

We previously removed support for doing that from sessionresolver following an incident in which Google briefly stopped servicing HTTP3.

It seems now dns.google supports QUIC and HTTP3 again.

Ideally, here we should re-add to sessionresolver the lines of code that were telling it to speak DNS-over-HTTPS using QUIC and HTTP3 with dns.google. We should also test with urlgetter that the service is indeed working.

To perform this kind of testing the procedure is roughly:

Lastly, we should also double check that we did not reduce the test coverage.

See https://github.com/ooni/probe/issues/1873 for historical context.

bassosimone commented 2 years ago

@yeganathan18 mentioned he wanted to work on this issue! ✨

bassosimone commented 2 years ago

I'm in touch with @yeganathan18 to land a fix for this problem!

bassosimone commented 2 years ago

Issue has been solved!