search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
754 stars 142 forks source link

android: allow installing all app flavours side by side #1989

Open bassosimone opened 2 years ago

bassosimone commented 2 years ago

This issue is about ensuring there are no conflicting names declared in the AndroidManifest.xml. We will consider it resolved when it would be possible to install stable{Dev,Experimental,Full}Release together at the same time.

This is a community request. It often happens that a member of the community has already the main OONI Probe Android app installed and configured and they want to help us with testing. Yet, if we provide them with an apk to install, there's the issue that currently the Android manifest is not general enough. Hence the new apk will fail to install because there are duplicate declaration that are also present on the stable OONI Probe Android version downloaded from the Play Store.

The fix here is simple: we just need to make the Android Manifest general enough.

bassosimone commented 2 years ago

So, as far as installing is concerned, https://github.com/ooni/probe-android/pull/478 solves the problem. However, there is a second order problem that the app crashes when, e.g., opening the proxy activity because of conflicting activity names. It seems this problem has been discussed on StackOverflow already.

arky commented 1 year ago

Additionally Icons should be differentiated to ensure that the correct flavors is selected. The stable release would use the standard ooni logo, but other version could have color variant or logo with a gear icon.

aanorbel commented 1 year ago

@arky , the various flavors have a different logos and names already.

arky commented 1 year ago

@aanorbel Tested on Android 11. Works as expected, plays nicely with stable release installed from playstore