search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
754 stars 142 forks source link

android: replace ooni/go-libtor with scripts compiling tor #2365

Closed bassosimone closed 1 year ago

bassosimone commented 1 year ago

As I explained in https://github.com/ooni/probe-cli/pull/1024, I am not satisfied about using go-libtor. Let me summarize again the issues I see here. The first issue is about being sure that the configure scripts pick up the right libraries. The second issue is about using hardening compile flags. I still think go-libtor is an amazing hack, but I would rather see us using a more conventional approach when cross compiling tor for android and iOS.

The parent issue is https://github.com/ooni/probe/issues/2273.

bassosimone commented 1 year ago

I cheated and changed the title. I spent too much time on this task and have worked out what I think is a better build for Android. I am now going to stop and call this task complete. We'll pick up this work again in the future. (Or, maybe, we'll switch to using Arti before the time comes that I have again time to look into go-libtor.)