search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
751 stars 142 forks source link

android: no prompt to enable notifications #2507

Closed bassosimone closed 8 months ago

bassosimone commented 12 months ago

Describe the bug

It seems I cannot get the app to prompt me to enable notifications in the system settings.

To Reproduce

I compiled the app for myself using the procedure at https://github.com/ooni/probe/issues/2504 (which entails using a custom signing key as opposed to the official one—perhaps we can improve this part of the process?). I installed the app accepting all the default settings. I verified that the settings did not contain notifications enabled for OONI Probe. I went into the settings were notifications were not enabled. I clicked to enable notifications but the settings still showed the notifications as disabled.

Expected behavior

Per the pre-release check-list that I am following, I should be prompted like I am prompted when I enable running in the background, i.e., with a system settings popup asking me to enable notifications.

Screenshots

photo1689940948

photo1689940969

System information (please complete the following information):

Additional context

I wonder whether linking a library for a functionality we do not use (i.e., notifications) is preferable over removing this dependency considering that we do seldomly use this functionality and we're not sure whether it would even work in countries with lots of censorship.

bassosimone commented 12 months ago

I am reopening this issue because there are two additional matters to discuss:

  1. we need to discuss internally whether the following popup is fine:

image

or whether we'd like another approach. Specifically, we may want to: ask for permission to send notifications and wrap the system dialog into our own model explaining why we need to send notifications.

  1. there is a clash between Android 13's request for notifications (i.e., notifications generated by the app that deal with nettests progress and completion) and our own push notification settings. Because Android system dialogs use the wording "notification" to describe the former, we probably need to change the copy of our settings to say push notifications explicitly, otherwise we would have rather confusing settings and wording.
bassosimone commented 11 months ago

We're going to ship the above popup in the upcoming v3.8.3 ooni/probe-android release. We're having an internal conversation regarding how it's best to proceed in terms of organizing dynamic permissions.