search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
750 stars 142 forks source link

android: torsf: route ip+net: netlinkrib: permission denied #2529

Closed bassosimone closed 9 months ago

bassosimone commented 10 months ago

On August 18, we observed that ooni/probe-android v3.8.3 causes a spike of torsf (tor + snowflake) anomalies. On August 21, we determined that Snowflake emits this error while running on an Android device:

route ip+net: netlinkrib: permission denied

This error is also described by snowflake#40278, which subsequently has been fixed by snowflake#158.

The reason why this error appeared in v3.8.3 is because it includes ooni/probe-cli's oonimkall v3.8.1, for which we upgraded the relevant pion libraries as part of its release process. We also failed to notice this issue during the QA that preceeded the Android release.

When the nature of the bug was clear to us, we instrumented the backend to mark all the torsf measurements produced by ooni/probe-android as failed. However, this was just a mitigation. We should consider this data quality issue solved when we will have fixed the issue in ooni/probe-cli, tested that it's WAI on Android, and released a new app version.

bassosimone commented 9 months ago

This issue should have been fixed by upgrading Snowflake, but we should check for ourselves on Android.

bassosimone commented 9 months ago

On second thought, I will close this issue now and reopen if needed.