ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
750 stars 142 forks source link

engine: stop using model.ArchivalMaybeBinaryData #2543

Open bassosimone opened 9 months ago

bassosimone commented 9 months ago

As part of https://github.com/ooni/probe/issues/2531 and, more specifically, of a quest to rationalize how we represent HTTP requests and responses and apply more aggressive scrubbing, I removed ArchivalMaybeBinaryData from most of the tree and replaced it with either ArchivalBinaryData or ArchivalMaybeBinaryString. A few usages of ArchivalMaybeBinaryData remain on tree. We should evaluate case by case whether to switch to ArchivalBinaryData or `ArchivalMaybeBinaryString.