search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
750 stars 142 forks source link

mobile: re-add support for riseupvpn #2560

Closed bassosimone closed 8 months ago

bassosimone commented 9 months ago

In https://github.com/ooni/probe-cli/pull/1365, I re-added riseupvpn as part of the experimental suite for probe-cli. We should do the same for mobile.

Note that now riseupvpn is a disabled-by-default experimental experiment that we can enable (or disable again) through the check-in API (so https://github.com/ooni/probe/issues/2558 applies to this specific case).

Also, note that now the engine does not score riseupvpn results. We treat riseupvpn as an experiment that cannot really yield an anomaly but rather just as something we can use to collect useful data.

Therefore, we should make sure to remove any interpretation logic for riseupvpn from mobile apps (assuming there is any) and just use riseupvpn as the other experimental experiments.

bassosimone commented 8 months ago

I'm removing the releaseBlocker flag because we determined with @aanorbel that this would cause us to delay the mobile release for too much time.