search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
761 stars 142 forks source link

engine: unify code implementing Submitter and Experiment.OpenReport #2608

Open bassosimone opened 1 year ago

bassosimone commented 1 year ago

The engine codebase allows submitting measurements using two mechanisms. There are methods of the engine.Experiment type and there is the engine.Submitter. We should probably have a single implementation implementing both APIs such that we don't need to change existing code but we reduce code complexity.

bassosimone commented 5 months ago

When implementing https://github.com/ooni/probe/issues/2607, we chose another approach, given that it was possible to adapt the code without doing this refactoring. We may still want to make this change sometime in the future.