probe-ios: after upgrading OONI Probe to a new version older measurements are deleted from the device

ooni / probe

OONI Probe network measurement tool for detecting internet censorship

https://ooni.org/install

BSD 3-Clause "New" or "Revised" License

749 stars 142 forks source link

probe-ios: after upgrading OONI Probe to a new version older measurements are deleted from the device #2625

Open hellais opened 8 months ago

hellais commented 8 months ago

Describe the bug

I have noticed in the past that whenever I upgrade to a newer version of OONI Probe (I think that's what is triggering it), all my past tests are deleted from the results screen.

Interestingly, the counter of the background tests does not seem to reset in the same way.

To Reproduce

Run a bunch of tests
Upgrade OONI Probe
Notice that all your test results have disappeared

Expected behavior

OONI Probe to not eat my past test results on upgrade.

System information (please complete the following information):

Device: iPhone 12
- OS: 17.0.3
- OONI Probe version: 3.8.4

aanorbel commented 7 months ago

So far I have not been able to reproduce this error. Starting with v3.8.2 and moving to various versions and updating to the latest in test flight and the results were still present on the iPhone 12 Pro Max running iOS 17.1.1.

@hellais , @sloncocs , I will need help reproducing this issue.

hellais commented 6 months ago

@aanorbel have you tried doing it with the non-testflight version of the app? Every time a new release comes out my stock OONI Probe version deletes all previous test results.

Do you have the non-test flight OONI Probe on iOS as well?

I would also suggest looking at the code for persisting results to the DB and understanding how that part works and what might be causing this deletion of data across upgrades.