search

ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
749 stars 142 forks source link

webconnectivitylte: missing "blocking" key inside `tcp_connect` #2687

Closed bassosimone closed 2 months ago

bassosimone commented 4 months ago

I noticed this when re-reading the spec. Not a big deal because backends are not using that. Still, for complete correctness we should possibly see to recompute this field.

Explorer uses this: https://github.com/ooni/explorer/blob/3b542cfac527f26bf55167e28fad89816c89fbe0/components/measurement/nettests/WebConnectivity.js#L492

I discussed the matter with @hellais and it seems the correct fix is https://github.com/ooni/explorer/issues/900 and we're going to close this issue as wontfix once that has been deployed.

bassosimone commented 2 months ago

Because https://github.com/ooni/explorer/issues/900 is complete, we can call this issue complete.