ooni / probe

OONI Probe network measurement tool for detecting internet censorship
https://ooni.org/install
BSD 3-Clause "New" or "Revised" License
749 stars 142 forks source link

httpclientx: fast recovery on error and endpoint index #2728

Closed bassosimone closed 1 month ago

bassosimone commented 1 month ago

To replace httpapi for test helpers, httpclientx needs two extra functionality:

  1. fast recovery in case a previous attempt failed (e.g., we immediately get connection reset by peer and, in such a case, it does not make sense to wait for a schedule interval before starting the next attempt);
  2. returning the index of the endpoint that succeeded, which is required to know which test helper we used.

Once we have implemented both, it is safe to move forward and use httpclientx for the test helpers.