oorb / oorb

An open-source orbit-computation package for Solar System objects.
GNU General Public License v3.0
56 stars 48 forks source link

Building de430 ephemerides fails #121

Closed Siltala closed 4 years ago

Siltala commented 4 years ago

After spending some time hitting my head against a wall with the ephemeris build problems seen on the CI I realized something: The de430 ephemerides no longer build on my local systems (Arch Linux , Ubuntu 18.04 and Ubuntu 20.04) either, failing on all systems with the same error as the CI (Error 28 which means out of disk space, though I can confirm that I have a lot of disk space?). The CI also confirms that Mac has the same problem and it's not linux specific.

So clearly this is -not- a Github Actions specific problem but was first revealed by the CI. Given that the makefile has not changed for 2 years either, something else must have changed somewhere that broke things. I don't know what, but I think this is a severe bug considering that these ephemerides are necessary to actually run oorb.

Siltala commented 4 years ago

Update: It turns out the error 28 actually comes from curl rather than bash (it turns out that curl's arguments in the makefile have, for some reason, been set up to fail silently without printing out any errors which further confused me)

In curl, error 28 means "server response timeout". For reference, the problem also occurs with curl from 2018 which definitely used to work fine, so it's also not due to a curl update on my end. For another test, I tried switching the makefile to use wget rather than curl and the problem completely disappeared. So, for some reason, it seems to me that the JPL server no longer plays nicely with curl in particular.

I think that possible solutions are:

Siltala commented 4 years ago

It seems that the problem has been solved at JPL's end at some point and the issue downloading from their server no longer occurs (as evidenced by the CI passing again)

I force-pushed all of my PRs to re-run the CI for them and you can indeed see that they pass now.