Closed emirotin closed 10 years ago
@Xyand -- is there any chance you could take a look at this?
Basically it'd be better if the package used mrt
not meteor
to bundle. For 0.6.0 this will be the same thing, assuming that meteor
is on the path. I'll make some notes on your commits explaining what I think will help.
I wish to add that using @nate-strauser's version locked on mrt 0.5.1 solved my issue
Good. Can you provide a link here so people have some way of running pre-0.6.0 meteorite on heroku for now?
@emirotin, Please check if this one works for you: https://github.com/Xyand/heroku-buildpack-meteorite
@Xyand nope, throws
Errors prevented bundling:
Exception while bundling application:
TypeError: Cannot call method 'toString' of undefined
at _.extend.minify.self.js.client (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/lib/bundler.js:428:49)
at Array.forEach (native)
at Function._.each._.forEach (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
at _.extend.minify (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/lib/bundler.js:427:7)
at Object.exports.bundle (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/lib/bundler.js:732:14)
at Object.Commands.push.func (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/meteor/meteor.js:415:28)
at main (/tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/meteor/meteor.js:665:22)
at /tmp/node-meteor-nVHq/.meteorite/meteors/meteor/meteor/45fef52095bb6726cc1b2f05008ad891c446100a/app/meteor/meteor.js:668:3
tar: /app/tmp/repo.git/.cache/bundle.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: Child returned status 2
tar: Exiting with failure status due to previous errors
! Push rejected, failed to compile Meteor app app
@nate-strauser's version still works
This should be fixed now.
I have a project locked on Meteor 0.5.9, from my smart.json:
It heavily relies on variable sharing across files (thanks to their concatenation) - the thing that changed in 0.6. That's why I cannot instantly migrate (and don't want to actually).
My local versions (work ok)
Last time I deployed to Heroku it went OK as well - it was 5 days ago. Today after deploy I start getting errors related to variables not defined.
In the deployment log I see
Though it installs v0.5.9 it feels like the code is ran with 0.6.0
Also the's — don't know if related